Add missing tests for core modules #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for error.ts including: - ExpectedError class constructor with and without source - handleError function for ExpectedError, AssertError, and unknown errors - withHandleError wrapper for sync and async functions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add tests for all predicate functions including: - isStringArray, isAbortSignal - isTheme, isCoordinator, isCurator - isSource, isMatcher, isSorter - isRenderer, isPreviewer, isAction - isSetting, isPickerParams, isOptions - isIncrementalMatcher 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add tests verifying that DisposableStack and AsyncDisposableStack are properly polyfilled in globalThis and their basic functionality works. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add integration tests for submatch functionality: - Dispatcher registration - Invalid context/params rejection - Valid submatch call processing - Optional parameter handling - Return value propagation Tests use real Denops instances to verify integration behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add comprehensive tests for custom configuration: - Unit tests for getSetting, getActionPickerParams, getPickerParams, listPickerNames - Integration tests for loadUserCustom with real Denops instances - Tests for default custom loading, user custom loading, reload option - Validation tests for picker and action names - Verbose option handling tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Remove async keyword from dispatch mock functions that don't use await. Use Promise.resolve() to maintain type compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The integration tests in custom_test.ts create temporary files with cache-busting fragments that cause coverage generation to fail when the temporary files are cleaned up but still referenced in coverage. This fix excludes the integration test from coverage while preserving all test functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 82.14% 83.45% +1.31%
==========================================
Files 27 31 +4
Lines 1798 1977 +179
Branches 185 200 +15
==========================================
+ Hits 1477 1650 +173
- Misses 318 324 +6
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Files Added
error_test.ts- Tests for ExpectedError and withHandleError functionalitycustom_test.ts- Tests for configuration loading and managementpredicate_test.ts- Tests for all type predicate functionspolyfill_test.ts- Tests for DisposableStack polyfillssubmatch_test.ts- Tests for submatch dispatcher functionalityTest Plan
deno task test)deno lint)deno task check)deno fmt)🤖 Generated with Claude Code