Update tabpage.{txt,jax} #2094
Open
Update tabpage.{txt,jax} #2094
+129
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mityu
reviewed
Jun 7, 2025
| > | ||
| +------ This width | ||
| | | ||
| <----+-----> |
There was a problem hiding this comment.
（翻訳とは直接関係はないです）
この行のインデントがタブではなくスペースで行われているんですが、本当はタブであるべきだったりしますかね？
There was a problem hiding this comment.
いつもの(タブ、スペースのMix)にした方がいいですね。
Comment on lines
+441
to
+442
| The 'tabpanel' and 'showtabpanel' options function similar to | ||
| 'statusline' or 'tabline'. |
There was a problem hiding this comment.
ここの部分、'tabpanel' が 'statusline' や 'tabline' と似た機能を持つというところはわかるのですが、'showtabpanel' は別でむしろ対応するのは 'laststatus' や 'showtabline' だと思うので、「'tabpanel' と 'showtabpanel' オプションは 'statusline' や 'tabline' オプションと同じ機能を持つ」と言われるとちょっと変な感じがするのですがどうでしょう？
There was a problem hiding this comment.
typo 報告スレに投げてみました。
Co-authored-by: mityu <[email protected]>
Co-authored-by: mityu <[email protected]>
Co-authored-by: mityu <[email protected]>
Co-authored-by: mityu <[email protected]>
|
原文更新しましたが、日本語訳は先行して修正していたので日付のみの更新です 👍 |
mityu
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabpanel関連は先行して直したりしてます。
vim-jp/issues#1433 (comment)
tabpaneloptの "wrap" 項目はpatch merge前削除されてます。