Skip to content

I made some minor modifications #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

stick
Copy link

@stick stick commented Mar 23, 2011

Loved this plugin and your approach with the subfiles based on filetype. I added a few things, one the replace on the tags didn't handle paths well so I changed the delimiter, also setup a loose filetype match that you can enable. I moved the tags file to under the skeleton directory so it stays out of the repo when people add their own tags and whatnot. I tried to break it up into commits so if you wish to cherry-pick or whatever that's fine. Documentation updates are included.

Thanks!

C

Chris MacLeod added 3 commits March 23, 2011 00:00
Added a .gitignore file to ignore tags since they are autogenerated.

Fixed the substitute section to use a different delimiter that handles
commands that return newlines and other things better.  A lot of common
commands and subs were failing because they had slashes contained and
that would throw substitute off.  A better approach might be to use
substitute() instead.

added a global option to allow loose filetype matching so you don't have
to include an underscore in the filename to get it to match a
sub-filetype skeleton.  It's turned off by default.
move the tags file to a tags directory under ~/.vim/skeleton this keeps
the user defined tags away from plugin tags (allowing the plugin to
potentionally set them one day).  It also keeps them out of the repo if
someone has it cloned to their .vim directory (very common with
pathogen).
Cleaned up whitespace from end of lines
make it handle a missing tagfile better
Copy link

@ellethee ellethee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I really not notice this pull request all this time?
Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants