fixes duplicate key error when limit operation is applied with UPDATE statement #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedyyytang
changed the title
hedyyytang
changed the title
hedyyytang
force-pushed
the
fix-limit-operation
branch
from
e93fcd3 to
e03357a
Compare
aaronm67
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert changes introduced in - 9bbc63a.
It breaks our existing
UPDATEstatement withLIMITClause.Before the fix, row ids are reindexed after the
LIMIToperation, which causes duplicate key error because the original row is not excluded from the unique key comparisonAfter the fix,
UPDATEstatement withLIMIT 1clause is executed correctlyTests
Added unit tests