Skip to content

Conversation

@indytechcook
Copy link

This updates to PSR-0 compliance and adds a componser.json for http://packagist.org/ compatibility.

Review on Reviewable

@ADmad
Copy link

ADmad commented Mar 5, 2012

The suggested changes would prevent the Vimeo class to be used on php 5.2 or below since it doesn't support namespaces. I don't see why one would limit the use of the class in this way.

On an unrelated note the index.php file currently throws numerous "undefined index" notices when error reporting is set to E_ALL. Would be nice if that would be fixed. Seeing that pull request is open without any response for over 2 months and last commit on the repo was on Sep 07, 2010 I wonder if Vimeo is really committed to maintaining this repo.

@bdougherty
Copy link
Contributor

Yeah, I don't think we can use namespaces here. I'm not sure how many people use this that aren't on 5.3, but we don't want to cut them out.

@bmeynell
Copy link

@bdougherty - at the very least a composer.json file would be helpful. See DailyMotions for example.

@benedyktdryl
Copy link

+1

@andyfleming
Copy link

+1 for adding a composer.json file

@andyfleming
Copy link

Please also tag a release (with git tagging), like git tag 1.0.0. It makes it easier to download a static copy of the repo through composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants