Project Params Hotfix (G-Research#62)

* Hotfix: Add support for experimentNames in getProjectParams * Fetch project params on selectedExperiment change
vinayan3 · Aug 28, 2024 · 051d41e · 051d41e
1 parent 7ba8118
commit 051d41e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/src/services/api/projects/projectsService.ts b/src/src/services/api/projects/projectsService.ts
@@ -24,14 +24,17 @@ function fetchActivityData(): IApiRequest<any> {
 
 function getProjectParams(
   sequences: string[] = ['metric'],
+  selectedExperimentNames: string[] = [],
 ): IApiRequest<IProjectParamsMetrics> {
-  const query = sequences.reduce(
-    (acc: string, sequence: string, index: number) => {
+  const query =
+    sequences.reduce((acc: string, sequence: string, index: number) => {
       acc += `${index === 0 ? '?' : '&'}sequence=${sequence}`;
       return acc;
-    },
-    '',
-  );
+    }, '') +
+    selectedExperimentNames.reduce((acc: string, experimentName: string) => {
+      acc += `&experiment_names=${experimentName}`;
+      return acc;
+    }, '');
   return API.get<IProjectParamsMetrics>(endpoints.GET_PROJECTS_PARAMS + query);
 }
 

diff --git a/src/src/services/models/explorer/metricsModelMethods.ts b/src/src/services/models/explorer/metricsModelMethods.ts
@@ -223,8 +223,10 @@ function getMetricsAppModelMethods(
   }
 
   function fetchProjectParamsAndUpdateState() {
+    const selectedExperimentNames =
+      model.getState()?.config?.select.selectedExperimentNames;
     projectsService
-      .getProjectParams(['metric'])
+      .getProjectParams(['metric'], selectedExperimentNames)
       .call()
       .then((data) => {
         const advancedSuggestions: Record<any, any> = getAdvancedSuggestion(