Skip to content

Commit

Permalink
add log pkg
Browse files Browse the repository at this point in the history
  • Loading branch information
travisjeffery committed Aug 6, 2018
1 parent 8e8c59b commit c3ed0de
Show file tree
Hide file tree
Showing 15 changed files with 117 additions and 30 deletions.
2 changes: 1 addition & 1 deletion _examples/sarama/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"testing"

"github.com/Shopify/sarama"
"github.com/apex/log"
"github.com/travisjeffery/jocko/jocko"
"github.com/travisjeffery/jocko/jocko/config"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
)

Expand Down
12 changes: 6 additions & 6 deletions jocko/broker.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import (
"github.com/travisjeffery/jocko/jocko/metadata"
"github.com/travisjeffery/jocko/jocko/structs"
"github.com/travisjeffery/jocko/jocko/util"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

var (
Expand Down Expand Up @@ -1098,13 +1098,13 @@ func (b *Broker) Leave() error {
if isLeader && numPeers > 1 {
future := b.raft.RemoveServer(raft.ServerID(b.config.ID), 0, 0)
if err := future.Error(); err != nil {
log.Error.Printf("remove ourself as raft peer error: %s", err)
log.Error.Printf("broker: remove ourself as raft peer error: %s", err)
}
}

if b.serf != nil {
if err := b.serf.Leave(); err != nil {
log.Error.Printf("leave LAN serf cluster error: %s", err)
log.Error.Printf("broker: leave LAN serf cluster error: %s", err)
}
}

Expand All @@ -1120,7 +1120,7 @@ func (b *Broker) Leave() error {
// Get the latest configuration.
future := b.raft.GetConfiguration()
if err := future.Error(); err != nil {
log.Error.Printf("get raft configuration error: %s", err)
log.Error.Printf("broker: get raft configuration error: %s", err)
break
}

Expand All @@ -1140,7 +1140,7 @@ func (b *Broker) Leave() error {

// Shutdown is used to shutdown the broker, its serf, its raft, and so on.
func (b *Broker) Shutdown() error {
log.Info.Printf("shutting down broker")
log.Info.Printf("broker: shutting down broker")
b.shutdownLock.Lock()
defer b.shutdownLock.Unlock()

Expand All @@ -1158,7 +1158,7 @@ func (b *Broker) Shutdown() error {
b.raftTransport.Close()
future := b.raft.Shutdown()
if err := future.Error(); err != nil {
log.Error.Printf("shutdown error: %s", err)
log.Error.Printf("broker: shutdown error: %s", err)
}
if b.raftStore != nil {
b.raftStore.Close()
Expand Down
2 changes: 0 additions & 2 deletions jocko/broker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"github.com/travisjeffery/jocko/jocko/config"
"github.com/travisjeffery/jocko/jocko/structs"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

func TestBroker_Run(t *testing.T) {
Expand Down Expand Up @@ -503,7 +502,6 @@ func TestBroker_Shutdown(t *testing.T) {

type fields struct {
id int32
logger log.Logger
logDir string
}

Expand Down
2 changes: 1 addition & 1 deletion jocko/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (ctx *Context) Err() error {
}

func (ctx *Context) String() string {
return fmt.Sprintf("ctx: %s", header)
return fmt.Sprintf("ctx: %s", ctx.header)
}

func (ctx *Context) Value(key interface{}) interface{} {
Expand Down
2 changes: 1 addition & 1 deletion jocko/fsm/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"

"github.com/travisjeffery/jocko/jocko/structs"
"upspin.io/log"
"github.com/travisjeffery/jocko/log"
)

func init() {
Expand Down
2 changes: 1 addition & 1 deletion jocko/fsm/fsm.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import (
opentracing "github.com/opentracing/opentracing-go"
"github.com/travisjeffery/jocko/jocko/structs"
"github.com/travisjeffery/jocko/jocko/util"
"github.com/travisjeffery/jocko/log"
"github.com/ugorji/go/codec"
"upspin.io/log"
)

var (
Expand Down
3 changes: 1 addition & 2 deletions jocko/fsm/fsm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ import (

stdopentracing "github.com/opentracing/opentracing-go"
"github.com/travisjeffery/jocko/jocko/structs"
"upspin.io/log"
)

func testStore(t *testing.T) *Store {
s, err := NewStore(log.New(), stdopentracing.GlobalTracer())
s, err := NewStore(stdopentracing.GlobalTracer())
if err != nil {
t.Fatalf("err: %s", err)
}
Expand Down
2 changes: 1 addition & 1 deletion jocko/leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import (
"github.com/travisjeffery/jocko/jocko/fsm"
"github.com/travisjeffery/jocko/jocko/metadata"
"github.com/travisjeffery/jocko/jocko/structs"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion jocko/replicator.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"time"

"github.com/cenkalti/backoff"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

// Client is used to request other brokers.
Expand Down
6 changes: 3 additions & 3 deletions jocko/serf.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/hashicorp/raft"
"github.com/hashicorp/serf/serf"
"github.com/travisjeffery/jocko/jocko/metadata"
"upspin.io/log"
"github.com/travisjeffery/jocko/log"
)

const (
Expand Down Expand Up @@ -72,7 +72,7 @@ func (b *Broker) lanNodeJoin(me serf.MemberEvent) {
if !ok {
continue
}
log.Info.Printf("adding LAN server: %s", meta.ID)
log.Info.Printf("broker: adding LAN server: %s", meta.ID)
// update server lookup
b.brokerLookup.AddBroker(meta)
if b.config.BootstrapExpect != 0 {
Expand All @@ -87,7 +87,7 @@ func (b *Broker) lanNodeFailed(me serf.MemberEvent) {
if !ok {
continue
}
log.Info.Printf("removing LAN server: %s", m.Name)
log.Info.Printf("broker: removing LAN server: %s", m.Name)
b.brokerLookup.RemoveBroker(meta)
}
}
Expand Down
2 changes: 1 addition & 1 deletion jocko/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (
"github.com/davecgh/go-spew/spew"
opentracing "github.com/opentracing/opentracing-go"
"github.com/travisjeffery/jocko/jocko/config"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

type contextKey string
Expand Down
7 changes: 4 additions & 3 deletions jocko/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@ import (
"github.com/stretchr/testify/require"
"github.com/travisjeffery/jocko/jocko"
"github.com/travisjeffery/jocko/jocko/config"
"github.com/travisjeffery/jocko/log"
"github.com/travisjeffery/jocko/protocol"
"upspin.io/log"
)

const (
topic = "test_topic"
)

func init() {
log.SetPrefix("server_test: ")
log.SetLevel("debug")
sarama.Logger = log.NewStdLogger(log.Debug)
sarama.Logger = log.NewStdLogger(log.New(log.DebugLevel, "server_test: sarama: "))
}

func TestProduceConsume(t *testing.T) {
Expand Down Expand Up @@ -167,7 +168,7 @@ func TestProduceConsume(t *testing.T) {
}

func TestConsumerGroup(t *testing.T) {
// t.Skip()
t.Skip()

s1, teardown1 := jocko.NewTestServer(t, func(cfg *config.Config) {
cfg.BootstrapExpect = 3
Expand Down
95 changes: 95 additions & 0 deletions log/log.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
package log

import (
stdlog "log"

"upspin.io/log"
)

var (
Debug = &logger{l: log.Debug}
Info = &logger{l: log.Info}
Error = &logger{l: log.Error}
)

type logger struct {
prefix string
l log.Logger
}

type Level = log.Level

var (
DebugLevel = log.DebugLevel
InfoLevel = log.InfoLevel
ErrorLevel = log.ErrorLevel
)

func New(level log.Level, prefix string) *logger {
l := &logger{prefix: prefix}
switch level {
case log.DebugLevel:
l.l = log.Debug
case log.InfoLevel:
l.l = log.Info
case log.ErrorLevel:
l.l = log.Error
}
return l
}

func SetPrefix(prefix string) {
for _, logger := range []*logger{Debug, Info, Error} {
logger.prefix = prefix
}
}

func SetLevel(level string) {
log.SetLevel(level)
}

func NewStdLogger(l log.Logger) *stdlog.Logger {
return log.NewStdLogger(l)
}

func (l *logger) Printf(format string, v ...interface{}) {
if l.prefix == "" {
l.l.Printf(format, v...)
} else {
l.l.Printf(l.prefix+format, v...)
}
}

func (l *logger) Print(v ...interface{}) {
if l.prefix == "" {
l.l.Print(v...)
} else {
l.l.Print(append([]interface{}{l.prefix}, v...)...)
}
}

func (l *logger) Println(v ...interface{}) {
if l.prefix == "" {
l.l.Println(v...)
} else {
l.l.Println(append([]interface{}{l.prefix}, v...)...)
}
}

func (l *logger) Fatal(v ...interface{}) {
if l.prefix == "" {
l.l.Fatal(v...)
} else {
l.l.Fatal(append([]interface{}{l.prefix}, v...)...)
}
}

func (l *logger) Fatalf(format string, v ...interface{}) {
if l.prefix == "" {
l.l.Fatalf(format, v...)
} else {
l.l.Fatalf(l.prefix+format, v...)
}
}

var _ log.Logger = (*logger)(nil)
2 changes: 1 addition & 1 deletion protocol/request_header.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func (r *RequestHeader) Decode(d PacketDecoder) error {

func (r *RequestHeader) String() string {
return fmt.Sprintf(
"request header: correlation id: %d, api key: %d, client: %s, size: %d",
"correlation id: %d, api key: %d, client: %s, size: %d",
r.CorrelationID,
r.APIKey,
r.ClientID,
Expand Down
6 changes: 0 additions & 6 deletions testutil/testutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,17 @@ package testutil
import (
"fmt"
"io/ioutil"
stdlog "log"
"os"
"strings"
"sync/atomic"
"testing"
"time"

"upspin.io/log"

dynaport "github.com/travisjeffery/go-dynaport"
"github.com/travisjeffery/jocko/jocko/config"
)

func TestConfig(t *testing.T) (string, *config.Config) {
stdlog.SetPrefix("jockotest")
log.SetLevel("debug")

dir := tempDir(t, "jocko")
config := config.DefaultConfig()
ports := dynaport.Get(3)
Expand Down

0 comments on commit c3ed0de

Please sign in to comment.