Skip to content

#54 handle websocket rejections#55

Open
hollandjake wants to merge 4 commits intovinissimus:masterfrom
hollandjake:#54-handle-websocket-rejections
Open

#54 handle websocket rejections#55
hollandjake wants to merge 4 commits intovinissimus:masterfrom
hollandjake:#54-handle-websocket-rejections

Conversation

@hollandjake
Copy link
Copy Markdown

Fixes #54

  • Test classes can now receive the early termination event as a raised Exception where the body of the exception is the closure message (incase validation is wanted to be done on the response)

  • Also added tests for quartz WebSocket endpoints as they were missing

- Same tests as the starlette app ones, just using the quart app
@hollandjake hollandjake force-pushed the #54-handle-websocket-rejections branch 2 times, most recently from 3fd4d13 to d145be5 Compare June 12, 2022 21:24
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 12, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.59%. Comparing base (916afb0) to head (c3bf21a).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   87.56%   87.59%   +0.03%     
==========================================
  Files           6        6              
  Lines         410      411       +1     
==========================================
+ Hits          359      360       +1     
  Misses         51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hollandjake hollandjake force-pushed the #54-handle-websocket-rejections branch 2 times, most recently from 50f2cdf to 57c4d20 Compare June 13, 2022 07:17
@hollandjake hollandjake force-pushed the #54-handle-websocket-rejections branch from 57c4d20 to 46e139a Compare June 13, 2022 07:22
@hollandjake
Copy link
Copy Markdown
Author

Finally got the build working, had to add numerous new tests and update a few packages as their dependencies were failing the builds

@masipcat masipcat self-requested a review June 17, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client unable to handle websocket connection rejections

2 participants