Adding support for providing domains as an environment variable#9
Open
JamesBelchamber wants to merge 1 commit intovinted:masterfrom
Open
Adding support for providing domains as an environment variable#9JamesBelchamber wants to merge 1 commit intovinted:masterfrom
JamesBelchamber wants to merge 1 commit intovinted:masterfrom
Conversation
Co-authored-by: Mania Kazemzadeh <[email protected]>
JamesBelchamber
force-pushed
the
domains-env-var
branch
from
91a7364 to
0690a2a
Compare
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR create a
CERTIFICATOR_DOMAINS_LISTenvironment variable which, if set, will bypass the reading of theCERTIFICATOR_DOMAINS_FILE.This is currently in use with a client so it's useful, and this version has been written to respect the existing functionality - offering upstream but happy to keep maintaining this as a friendly fork if you don't want it (or don't want it yet) 🙂