Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle class name change #2483

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle class name change #2483

wants to merge 2 commits into from

Conversation

Pessimistress
Copy link
Collaborator

Closes #2465

  • Consistently handle props.className change in react-mapbox and react-maplibre
  • Test for Marker component className prop change
  • Not changing mapbox-legacy because marker.toggleClassName does not exist in v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang Awaiting requested review from chrisgervang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Marker className changes do not change when props change
1 participant
@Pessimistress