Add more params: datapoints_to_alarm and actions_enabled #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betabandido
reviewed
Dec 16, 2020
Member
betabandido
left a comment
betabandido
left a comment
There was a problem hiding this comment.
Thanks for this PR. And sorry for the late response. I have added a comment with a small change request.
|
|
||
| variable "default_datapoints_to_alarm" { | ||
| description = "The default amount of datapoints to alarm." | ||
| default = 2 |
Member
There was a problem hiding this comment.
While true is the default value for actions_enabled, it seems there is no default value for datapoints_to_alarm. The AWS UI seems to set this value to 1 by default.
I think we can set the default to null here, just in case users don't want to override this value. In that case AWS will set whatever value they have defined as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@betabandido Can you please take a look?
We need to set some more params on
aws_cloudwatch_metric_alarm.