-
-
Notifications
You must be signed in to change notification settings - Fork 269
feat: add deepseek provider #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tangbiubiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for DeepSeek models by integrating a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the DeepSeek provider, including configuration examples in .env.example and README.md, and the necessary provider implementation in codebase_rag/providers/base.py. The changes are well-structured. My feedback focuses on improving documentation consistency, ensuring type consistency in the new provider implementation, and encouraging the addition of unit tests for the new functionality to maintain code quality.
| # CYPHER_MODEL=gemini-2.5-flash | ||
| # CYPHER_API_KEY=your-google-api-key | ||
|
|
||
| # Example 6: All DeepSeek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for this! PR #161 adds LiteLLM support (coming soon), which handles DeepSeek along with 100+ other providers - see https://docs.litellm.ai/docs/providers/deepseek We'd suggest closing this PR to avoid maintaining separate provider classes for each cloud service. If you think there's value in having a dedicated DeepSeek provider that LiteLLM doesn't cover, let us know - happy to hear your thoughts. |
The deepseek provider has been added.
And the corresponding modifications have been made to the
.env.exampleandREADME.