Span API support #51
Open
Span API support #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalsong
force-pushed
the
feature/span-support
branch
from
762b60b to
907a53f
Compare
vitalsong
force-pushed
the
develop
branch
2 times, most recently
from
0076124 to
daf6171
Compare
vitalsong
force-pushed
the
feature/span-support
branch
from
907a53f to
79aeeb3
Compare
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
|
TODO: add span iterators |
- Remove auto cast arr_real -> arr_cmplx; - Add `complex(re)` function; - Add `span` implementation; - Return `span` from `slice` function for step=1; - Remove `base_array` reference from `slice`; - Check same array by pointer range; - Simplify cast for `cmplx_t` type; - Add `span` instead `base_array` for some `math` functions; - Update tests;
vitalsong
force-pushed
the
feature/span-support
branch
from
b4514df to
f646656
Compare
vitalsong
force-pushed
the
feature/span-support
branch
from
f646656 to
52fd89b
Compare
- Rename `const_slice_t` to `slice_t`; - Add const initialization for `base_slice_t`;
vitalsong
force-pushed
the
feature/span-support
branch
from
978323b to
66669f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complex(re)function;spanimplementation;spanfromslicefunction for step=1;base_arrayreference fromslice;cmplx_ttype;spaninsteadbase_arrayfor somemathfunctions;