-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): make ImportMetaEnv strictly available #19077
feat(types): make ImportMetaEnv strictly available #19077
Conversation
Co-authored-by: 翠 / green <[email protected]>
I'll handle the lint error later. |
Co-authored-by: 翠 / green <[email protected]>
Would you add a document about this here? |
What do you think of this change? |
Co-authored-by: Bjorn Lu <[email protected]>
d184511
In the last meeting, we decided to go with an |
/ecosystem-ci run |
commit: |
This comment was marked as duplicate.
This comment was marked as duplicate.
📝 Ran ecosystem CI on
✅ analogjs, react-router, previewjs, quasar, vite-plugin-pwa, vike, ladle, nuxt, qwik, laravel, waku, vite-plugin-react-swc, rakkas, vite-plugin-vue, vitepress, unocss, vite-setup-catalogue, vite-environment-examples, storybook, vite-plugin-react, sveltekit, vitest, vuepress, vite-plugin-cloudflare, marko, astro |
This PR only changes the types, so the failure of histoire is probably unrelated. |
Description
Even if you want to make the type of
ImportMetaEnv
strict, you can't because[key: string]: any
is specified. However, users should be able to choose whether to make the type strict or not.