Skip to content

mysql/json: settle values when parsing, so reading one cannot change it #20723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
arthurschreiber wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

mysql/json: settle values when parsing, so reading one cannot change it #20723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a1ed5b
mysql/json: reject numbers a double cannot hold, as MySQL does
arthurschreiber Jul 28, 2026
f4aa5ec
mysql/json: cover the exponent spellings called out on the issue
arthurschreiber Jul 28, 2026
e68bd7e
mysql/json: bound the exponent as written, not just as converted
arthurschreiber Jul 28, 2026
fa351ff
mysql/json: read numbers by JSON's grammar, not Go's
arthurschreiber Jul 28, 2026
fe181de
mysql/json: stop reading nan as a number
arthurschreiber Jul 28, 2026
b450fe6
mysql/json: decide what a double can hold the way MySQL decides it
arthurschreiber Jul 28, 2026
139a987
mysql/json: keep each significand digit to two roundings
arthurschreiber Jul 28, 2026
770f8c7
mysql/json: settle values when parsing, so reading one cannot change it
arthurschreiber Jul 28, 2026
2180b6f
mysql/json: move parseNumberType to the test that is its last reader
arthurschreiber Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/mysql/json/marshal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ func (w *sqlWriter) writeNumber(top bool) error {
// Use the parser's readFloat to validate number grammar, rejecting
// malformed inputs like "1+2", "1..2", or "1e+" that a simple
// character-class loop would accept.
n, ok := readFloat(w.data[w.pos:])
n, _, _, ok := readFloat(w.data[w.pos:])
if !ok || n == 0 {
return fmt.Errorf("invalid number at position %d in JSON", w.pos)
}
Expand Down
Loading
Loading