mysqlctl: prevent closeBackupFiles from cancelling context on successful file close, protecting in-flight S3/Ceph uploads - #20771

Open

jdoupe wants to merge 14 commits into

vitessio:mainfrom

jdoupe:fix-extrabackupengine-closetimeout

Commits on Jul 31, 2026

mysqlctl: prevent closeBackupFiles from cancelling context on successful file close, protecting in-flight S3/Ceph uploads
jdoupe
committed
3807257
Potential fix for pull request finding

jdoupe
and
Copilot
committed
a84763b
mysqlctl: drain async S3/Ceph uploads and check their error before finalizing or aborting an xtrabackup
jdoupe
committed
c678c1f
mysqlctl: poll the done channel non-blockingly in closeBackupFiles tests so require.Eventually's deadline is actually enforced
jdoupe
committed
66e68e0
mysqlctl: replace fixed sleep with require.Never polling in xtrabackup watchdog test
jdoupe
committed
b43d822
azblob: cancel uploads on the per-file context too, so a stalled upload can't block AbortBackup
jdoupe
committed
bee1ed9
mysqlctl: make the close-files success watchdog test deterministic with a CI-safe timeout
jdoupe
committed
f887d60
mysqlctl: use a CI-safe deadline for the watchdog timeout test and group the test helper type at the top of the file
jdoupe
committed
dd62a77
mysqlctl: join the closeBackupFiles watchdog goroutine before returning so no cancel can fire after a successful close\nmysqlctl: guard the closeBackupFiles watchdog with a mutex so a successful cl…
jdoupe
committed
7b5062d
azblob: use a CI-safe 30s deadline in the mergeCancel context tests
jdoupe
committed
7049f3e
- mysqlctl: document the irreducible boundary race in the closeBackupFiles watchdog
jdoupe
committed
ebc3977

Commits on Aug 4, 2026

test(mysqlctl): use require.ErrorIs for error assertion in TestCloseBackupFilesCancelsOnRealTimeout
jdoupe
committed
60ce8aa

Commits on Aug 5, 2026