Update maintainers and code owners project lists - #20772
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Pull request overview
Updates active maintainer records and CODEOWNERS assignments to reflect current project participation.
Changes:
- Moves inactive maintainers to the past-maintainers list.
- Reassigns ownership across major project areas.
- Updates VTAdmin and security expertise.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
MAINTAINERS.md |
Revises maintainers and expertise assignments. |
.github/CODEOWNERS |
Reassigns review ownership to active contributors. |
|
Thanks for putting this together, @mattlord ❤️ — the overall direction looks right to me, and the new entries for me largely match where I've actually been working. A few notes from cross-checking against my recent activity:
MAINTAINERS.md "Areas of expertise" needs the same pass as the maintainer list. Only VTAdmin and Security were updated, so after this change:
I'm happy to be listed under Evaluation Engine and Query Serving (and Parser, per the above). The others need a call from you on who picks them up or whether the section gets dropped. |
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
MAINTAINERS.md:65
- Moving these maintainers to the past-maintainer list is incomplete: the expertise section still routes work to
systay,dbussink,harshit-gangal,rohit-nayak-ps, andshlomi-noach, while.github/CODEOWNERSstill assigns@systayand@harshit-gangalas the only owners of/go/vt/vtexplain(and retains@beingnoble03for vreplication). This leaves routing contradictory and vtexplain without an active owner. Remove or replace all remaining references to the newly inactive maintainers.
* Andres Taylor ([systay](https://github.com/systay)) andres@planetscale.com
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20772 +/- ##
==========================================
+ Coverage 69.67% 77.51% +7.84%
==========================================
Files 1614 737 -877
Lines 216793 124745 -92048
==========================================
- Hits 151044 96696 -54348
+ Misses 65749 28049 -37700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Per #20772 (comment): add arthurschreiber to /go/mysql and /.github/workflows/, remove from /go/vt/vitessdriver and /go/vt/vterrors, and list under Parser, Evaluation Engine, and Query Serving areas of expertise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b66b5d126
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Matt Lord <mattalord@gmail.com>
Description
This PR adjusts the maintainer and codeowners lists.
Once this is merged then I will open a ticket with CNCF to have the official project maintainer list updated there as well.
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure