Skip to content

Update maintainers and code owners project lists - #20772

Open
mattlord wants to merge 5 commits into
mainfrom
update_maintainers_codeowners
Open

Update maintainers and code owners project lists#20772
mattlord wants to merge 5 commits into
mainfrom
update_maintainers_codeowners

Conversation

@mattlord

@mattlord mattlord commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This PR adjusts the maintainer and codeowners lists.

Once this is merged then I will open a ticket with CNCF to have the official project maintainer list updated there as well.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Signed-off-by: Matt Lord <mattalord@gmail.com>
Copilot AI review requested due to automatic review settings July 30, 2026 21:10
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 30, 2026
@github-actions github-actions Bot added this to the v25.0.0 milestone Jul 30, 2026
@vitess-bot

vitess-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates active maintainer records and CODEOWNERS assignments to reflect current project participation.

Changes:

  • Moves inactive maintainers to the past-maintainers list.
  • Reassigns ownership across major project areas.
  • Updates VTAdmin and security expertise.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
MAINTAINERS.md Revises maintainers and expertise assignments.
.github/CODEOWNERS Reassigns review ownership to active contributors.

Comment thread .github/CODEOWNERS
Comment thread MAINTAINERS.md
@mattlord mattlord added Backport to: release-23.0 Needs to be backport to release-23.0 Backport to: release-24.0 Needs to be backport to release-24.0 Type: Documentation Component: General Changes throughout the code base Type: Internal Cleanup and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 30, 2026
@mattlord
mattlord requested review from a team July 30, 2026 21:20
@arthurschreiber

Copy link
Copy Markdown
Member

Thanks for putting this together, @mattlord ❤️ — the overall direction looks right to me, and the new entries for me largely match where I've actually been working. A few notes from cross-checking against my recent activity:

  • Could you add me to /go/mysql and /.github/workflows/?
  • /go/pools (sole) — my pooling work has been in dbconnpool/tabletserver, not go/pools. I'm fine keeping it, just noting it.
  • /go/vt/vitessdriver and /go/vt/vterrors — no recent activity from me on either.

MAINTAINERS.md "Areas of expertise" needs the same pass as the maintainer list. Only VTAdmin and Security were updated, so after this change:

  • Parser, Evaluation Engine, Online DDL, and Java would list zero active maintainers.
  • Query Serving, Planner, Builds, Resharding, and Cluster Management still list people this PR moves to Past Maintainers.

I'm happy to be listed under Evaluation Engine and Query Serving (and Parser, per the above). The others need a call from you on who picks them up or whether the section gets dropped.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Copilot AI review requested due to automatic review settings August 3, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

MAINTAINERS.md:65

  • Moving these maintainers to the past-maintainer list is incomplete: the expertise section still routes work to systay, dbussink, harshit-gangal, rohit-nayak-ps, and shlomi-noach, while .github/CODEOWNERS still assigns @systay and @harshit-gangal as the only owners of /go/vt/vtexplain (and retains @beingnoble03 for vreplication). This leaves routing contradictory and vtexplain without an active owner. Remove or replace all remaining references to the newly inactive maintainers.
* Andres Taylor ([systay](https://github.com/systay)) andres@planetscale.com

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.51%. Comparing base (70c7a72) to head (06e64ea).
⚠️ Report is 464 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20772      +/-   ##
==========================================
+ Coverage   69.67%   77.51%   +7.84%     
==========================================
  Files        1614      737     -877     
  Lines      216793   124745   -92048     
==========================================
- Hits       151044    96696   -54348     
+ Misses      65749    28049   -37700     
Flag Coverage Δ
partial 77.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Per #20772 (comment):
add arthurschreiber to /go/mysql and /.github/workflows/, remove from
/go/vt/vitessdriver and /go/vt/vterrors, and list under Parser,
Evaluation Engine, and Query Serving areas of expertise.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Copilot AI review requested due to automatic review settings August 3, 2026 14:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Matt Lord <mattalord@gmail.com>
Copilot AI review requested due to automatic review settings August 3, 2026 19:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@mattlord
mattlord marked this pull request as ready for review August 3, 2026 20:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b66b5d126

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread MAINTAINERS.md
Signed-off-by: Matt Lord <mattalord@gmail.com>
Copilot AI review requested due to automatic review settings August 3, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to: release-23.0 Needs to be backport to release-23.0 Backport to: release-24.0 Needs to be backport to release-24.0 Component: General Changes throughout the code base Type: Documentation Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants