Skip to content

[release-24.0] Add zizmor check to the static checks workflow (#19149) #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vitess-bot wants to merge 1 commit into
base: release-24.0
Choose a base branch
from
Draft

[release-24.0] Add zizmor check to the static checks workflow (#19149) #20811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/arewefastyet_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: arewefastyet comment
permissions: read-all

on:
pull_request_target:
pull_request_target: # zizmor: ignore[dangerous-triggers] never checks out or runs PR code
types: [labeled]

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/assign_milestone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Assign Milestone

on:
pull_request_target:
pull_request_target: # zizmor: ignore[dangerous-triggers] only checks out the base ref, never PR code
types: [opened]

permissions:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/check_make_vtadmin_web_proto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,13 @@ jobs:

- name: Setup Node
if: steps.changes.outputs.proto_changes == 'true'
<<<<<<< HEAD
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
=======
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +67 to +73
with:
# node-version should match package.json
node-version: '22.13.1'
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/cluster_endtoend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,28 @@ jobs:
if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'minio')
uses: ./.github/actions/setup-minio

<<<<<<< HEAD
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
# 'consul' is the only need that triggers `make tools`, which installs both Consul and ZooKeeper.
# There is no separate 'zookeeper' need, so 'consul' is the correct proxy for "this shard needs ZooKeeper".
- name: Cache ZooKeeper
if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'consul')
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: dist/vt-zookeeper-*
key: zookeeper-${{ hashFiles('build.env', 'bootstrap.sh') }}

=======
# 'consul' is the only need that triggers `make tools`, which installs both Consul and ZooKeeper.
# There is no separate 'zookeeper' need, so 'consul' is the correct proxy for "this shard needs ZooKeeper".
- name: Cache ZooKeeper
if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'consul')
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
with:
path: dist/vt-zookeeper-*
key: zookeeper-${{ hashFiles('build.env', 'bootstrap.sh') }}

>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +185 to +206
- name: Install Consul and ZooKeeper
if: steps.changes.outputs.end_to_end == 'true' && contains(matrix.needs, 'consul')
run: make BUILD_PROTOC=0 tools
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_opened_tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ permissions:
contents: read

on:
pull_request_target:
pull_request_target: # zizmor: ignore[dangerous-triggers] only checks out the base ref, never PR code
types: [opened]

jobs:
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/static_checks_etc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,13 @@ jobs:

- name: Setup Node
if: steps.changes.outputs.proto_changes == 'true'
<<<<<<< HEAD
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
=======
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +225 to +231
with:
# make proto requires newer node than the pre-installed one
node-version: '22.13.1'
Expand Down Expand Up @@ -251,3 +257,9 @@ jobs:
echo "$output"
echo ""
exit 1

- name: Run zizmor 🌈
uses: zizmorcore/zizmor-action@3dc1ecc9bcb9e94e9b2c709687979e1298497054 # v0.6.2
with:
advanced-security: false
annotations: true
6 changes: 6 additions & 0 deletions .github/workflows/vtadmin_web_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,13 @@ jobs:
- name: Tune the OS
uses: ./.github/actions/tune-os

<<<<<<< HEAD
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
=======
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +45 to +51
with:
# node-version should match package.json
node-version: '22.13.1'
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/vtadmin_web_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,13 @@ jobs:
- name: Tune the OS
uses: ./.github/actions/tune-os

<<<<<<< HEAD
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
=======
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +45 to +51
with:
# node-version should match package.json
node-version: '22.13.1'
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/vtadmin_web_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,13 @@ jobs:
- name: Tune the OS
uses: ./.github/actions/tune-os

<<<<<<< HEAD
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
||||||| parent of 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
=======
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 # zizmor: ignore[cache-poisoning] this workflow publishes no artifacts
>>>>>>> 74844882a2 (Add `zizmor` check to the static checks workflow (#19149))
Comment on lines +40 to +46
with:
# node-version should match package.json
node-version: '22.13.1'
Expand Down
Loading