Skip to content

[main] Upgrade the Golang version to go1.27.0 #20875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitess-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[main] Upgrade the Golang version to go1.27.0 #20875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e92974
bump go version to go1.27.0
vitess-bot[bot] Aug 21, 2026
9ebb5b7
Changes for go 1.27
mattlord Aug 21, 2026
2133c3a
More fixes
mattlord Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: "2"
run:
go: "1.26"
go: "1.27"
linters:
default: none
enable:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ $(PROTO_GO_OUTS): minimaltools proto/*.proto
# This rule builds the bootstrap images for all flavors.
DOCKER_IMAGES_FOR_TEST = mysql80 mysql84 percona80 percona84
DOCKER_IMAGES = common $(DOCKER_IMAGES_FOR_TEST)
BOOTSTRAP_VERSION=59
BOOTSTRAP_VERSION=60
ensure_bootstrap_version:
find docker/ -type f -exec sed -i "s/^\(ARG bootstrap_version\)=.*/\1=${BOOTSTRAP_VERSION}/" {} \;
sed -i 's/\(^.*flag.String(\"bootstrap-version\",\) *\"[^\"]\+\"/\1 \"${BOOTSTRAP_VERSION}\"/' test.go
Expand Down
6 changes: 5 additions & 1 deletion docker/bootstrap/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,8 @@ List of changes between bootstrap image versions.

## [59] - 2026-08-15
### Changes
- Update build to golang 1.26.6
- Update build to golang 1.26.6

## [60] - 2026-08-21
### Changes
- Update build to golang 1.27.0
2 changes: 1 addition & 1 deletion docker/bootstrap/Dockerfile.common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG image=golang:1.26.6-bookworm@sha256:433f9dc4f8ea3a1ce4e28f9f15d0f7c056b10475307f886d6f1ac1ccc4abd976
ARG image=golang:1.27.0-bookworm@sha256:6033334f349f3912236ed6a06c5ed066605e58632dc415779b0d00a1568afa8d

# Build the Vitess Go binaries
FROM $image

Check warning on line 18 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Region Sharding example using etcd on Ubuntu

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $image results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 18 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using zk2 on Ubuntu

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $image results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 18 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Local example using etcd on Ubuntu

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $image results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 18 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Java Docker Test

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $image results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 18 in docker/bootstrap/Dockerfile.common

View workflow job for this annotation

GitHub Actions / Docker Test Cluster

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG $image results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

# Install Vitess build dependencies
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y && apt-get install -y --no-install-recommends \
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Build the Vitess Go binaries
FROM golang:1.26.6-trixie@sha256:23fdfd3a6abc97c81e32a724cdd1cf541c06c416eb04d717815f4ed7c75623d0 AS go-builder
FROM golang:1.27.0-trixie@sha256:31df75a0f51705bb15c74cacaeadb6596ae270cea9ec05138928de7e2d1f65e8 AS go-builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.mysql80
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-bookworm@sha256:433f9dc4f8ea3a1ce4e28f9f15d0f7c056b10475307f886d6f1ac1ccc4abd976 AS go-builder
FROM golang:1.27.0-bookworm@sha256:6033334f349f3912236ed6a06c5ed066605e58632dc415779b0d00a1568afa8d AS go-builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.mysql84
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-trixie@sha256:23fdfd3a6abc97c81e32a724cdd1cf541c06c416eb04d717815f4ed7c75623d0 AS go-builder
FROM golang:1.27.0-trixie@sha256:31df75a0f51705bb15c74cacaeadb6596ae270cea9ec05138928de7e2d1f65e8 AS go-builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.percona80
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-bookworm@sha256:433f9dc4f8ea3a1ce4e28f9f15d0f7c056b10475307f886d6f1ac1ccc4abd976 AS go-builder
FROM golang:1.27.0-bookworm@sha256:6033334f349f3912236ed6a06c5ed066605e58632dc415779b0d00a1568afa8d AS go-builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/lite/Dockerfile.percona84
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-trixie@sha256:23fdfd3a6abc97c81e32a724cdd1cf541c06c416eb04d717815f4ed7c75623d0 AS go-builder
FROM golang:1.27.0-trixie@sha256:31df75a0f51705bb15c74cacaeadb6596ae270cea9ec05138928de7e2d1f65e8 AS go-builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/vttestserver/Dockerfile.mysql80
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-bookworm@sha256:433f9dc4f8ea3a1ce4e28f9f15d0f7c056b10475307f886d6f1ac1ccc4abd976 AS builder
FROM golang:1.27.0-bookworm@sha256:6033334f349f3912236ed6a06c5ed066605e58632dc415779b0d00a1568afa8d AS builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion docker/vttestserver/Dockerfile.mysql84
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.26.6-bookworm@sha256:433f9dc4f8ea3a1ce4e28f9f15d0f7c056b10475307f886d6f1ac1ccc4abd976 AS builder
FROM golang:1.27.0-bookworm@sha256:6033334f349f3912236ed6a06c5ed066605e58632dc415779b0d00a1568afa8d AS builder

# Allows docker builds to set the BUILD_NUMBER
ARG BUILD_NUMBER
Expand Down
39 changes: 18 additions & 21 deletions examples/demo/demo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,27 +62,25 @@ func main() {

func runCluster() {
cluster = &vttest.LocalCluster{
Config: vttest.Config{
Topology: &vttestpb.VTTestTopology{
Keyspaces: []*vttestpb.Keyspace{{
Name: "customer",
Shards: []*vttestpb.Shard{{
Name: "-80",
}, {
Name: "80-",
}},
Topology: &vttestpb.VTTestTopology{
Keyspaces: []*vttestpb.Keyspace{{
Name: "customer",
Shards: []*vttestpb.Shard{{
Name: "-80",
}, {
Name: "product",
Shards: []*vttestpb.Shard{{
Name: "0",
}},
Name: "80-",
}},
},
SchemaDir: path.Join(os.Getenv("VTROOT"), "examples/demo/schema"),
MySQLBindHost: "0.0.0.0",
// VSchemaDDLAuthorizedUsers allows you to experiment with vschema DDLs.
VSchemaDDLAuthorizedUsers: "%",
}, {
Name: "product",
Shards: []*vttestpb.Shard{{
Name: "0",
}},
}},
},
SchemaDir: path.Join(os.Getenv("VTROOT"), "examples/demo/schema"),
MySQLBindHost: "0.0.0.0",
// VSchemaDDLAuthorizedUsers allows you to experiment with vschema DDLs.
VSchemaDDLAuthorizedUsers: "%",
}
env, err := vttest.NewLocalTestEnv(12345)
if err != nil {
Expand Down Expand Up @@ -232,21 +230,20 @@ func resultToMap(title string, qr *sqltypes.Result) map[string]any {

func streamQuerylog(port int) (<-chan string, error) {
request := fmt.Sprintf("http://localhost:%d/debug/querylog", port)
resp, err := http.Get(request)
resp, err := http.Get(request) //nolint:bodyclose // the body is closed by the reader goroutine below
if err != nil {
log.Error(fmt.Sprintf("Error reading stream: %v: %v", request, err))
return nil, err
}
defer resp.Body.Close()
ch := make(chan string, 100)
go func() {
defer resp.Body.Close()
buffered := bufio.NewReader(resp.Body)
for {
str, err := buffered.ReadString('\n')
if err != nil {
log.Error(fmt.Sprintf("Error reading stream: %v: %v", request, err))
close(ch)
resp.Body.Close()
return
}
splits := strings.Split(str, "\t")
Expand Down
Loading
Loading