Skip to content

[main] Upgrade the Golang version to go1.27.1 - #20981

Open
vitess-bot[bot] wants to merge 2 commits into
mainfrom
upgrade-go-to-1.27.1-on-main
Open

[main] Upgrade the Golang version to go1.27.1#20981
vitess-bot[bot] wants to merge 2 commits into
mainfrom
upgrade-go-to-1.27.1-on-main

Conversation

@vitess-bot

@vitess-bot vitess-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This Pull Request bumps the Golang version to go1.27.1 and the bootstrap version to 61.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

cc @vitessio/release

Copilot AI balanced review requested due to automatic review settings September 3, 2026 00:53
@vitess-bot vitess-bot Bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build labels Sep 3, 2026
@vitess-bot
vitess-bot Bot requested a review from a team September 3, 2026 00:53
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 3, 2026
@vitess-bot

vitess-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot

vitess-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@github-actions github-actions Bot added this to the v25.0.0 milestone Sep 3, 2026
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Sep 3, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copilot AI reviewed Sep 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Go versions, container references, digests, and bootstrap metadata are consistently updated across the codebase.

Pull request overview

Upgrades Vitess’s Go toolchain from 1.27.0 to 1.27.1 and advances bootstrap images to version 61.

Changes:

  • Aligns all Go modules on Go 1.27.1.
  • Updates pinned Go container images and digests.
  • Records and configures bootstrap version 61.
File summaries
File Description
go.mod Updates the primary Go version.
tools/addlicense/go.mod Updates the addlicense tool module.
tools/gofumpt/go.mod Updates the gofumpt tool module.
tools/goimports/go.mod Updates the goimports tool module.
tools/golangci-lint/go.mod Updates the lint tool module.
tools/gotestsum/go.mod Updates the test runner module.
tools/goyacc/go.mod Updates the parser generator module.
Makefile Advances the bootstrap version to 61.
test.go Uses bootstrap version 61 by default.
docker/bootstrap/Dockerfile.common Updates the pinned Go builder image.
docker/bootstrap/CHANGELOG.md Documents bootstrap image version 61.
docker/lite/Dockerfile Updates the default lite image builder.
docker/lite/Dockerfile.mysql80 Updates the MySQL 8.0 builder.
docker/lite/Dockerfile.mysql84 Updates the MySQL 8.4 builder.
docker/lite/Dockerfile.percona80 Updates the Percona 8.0 builder.
docker/lite/Dockerfile.percona84 Updates the Percona 8.4 builder.
docker/vttestserver/Dockerfile.mysql80 Updates the MySQL 8.0 test-server builder.
docker/vttestserver/Dockerfile.mysql84 Updates the MySQL 8.4 test-server builder.
Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@promptless

promptless Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Promptless documentation updates

@arthurschreiber arthurschreiber removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 3, 2026
@vitess-bot
bump go version to go1.27.1
f025806 
Signed-off-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 4, 2026 00:50
@vitess-bot
vitess-bot Bot force-pushed the upgrade-go-to-1.27.1-on-main branch from bab2e08 to f025806 Compare September 4, 2026 00:50
Copilot AI reviewed Sep 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All active Go and bootstrap references are consistently updated, with previous versions remaining only in historical or dependency records.

Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@arthurschreiber arthurschreiber mentioned this pull request Sep 4, 2026
Open
5 tasks
@arthurschreiber @claude
docker: pin the multi-platform index digests of the go1.27.1 images
15c70d0 
The upgrade tool pinned the linux/amd64 child manifests, which cannot
be built natively on arm64. Pin the index digests the tags point to
instead, as #21007 makes the tool do from now on.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019WFEQBZgAgYxc3sPhdZeQp
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Copilot AI review requested due to automatic review settings September 4, 2026 11:00
Copilot AI reviewed Sep 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T11:02:52.907217Z 15c70d0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@arthurschreiber arthurschreiber mentioned this pull request Sep 4, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@github-actions github-actions[bot] github-actions[bot] approved these changes
@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner
@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner
@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner
@mhamza15 mhamza15 Awaiting requested review from mhamza15 mhamza15 is a code owner
@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Benchmark me Add label to PR to run benchmarks Component: Build/CI Component: Docker Component: General Changes throughout the code base go Type: CI/Build Type: Dependencies Dependency updates

Projects

None yet

Milestone

v25.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@arthurschreiber