-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugin-azure-key-vault] Add ability to read property values from Azure KeyVault #5182
Open
abudevich
wants to merge
1
commit into
vividus-framework:master
Choose a base branch
from
abudevich:vividus-azure-key-vault-properties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[plugin-azure-key-vault] Add ability to read property values from Azure KeyVault #5182
abudevich
wants to merge
1
commit into
vividus-framework:master
from
abudevich:vividus-azure-key-vault-properties
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Jul 3, 2024
vividus-engine/src/main/java/org/vividus/configuration/AbstractPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
vividus-plugin-azure-resource-manager/src/main/resources/vividus-plugin/spring.xml
Outdated
Show resolved
Hide resolved
vividus/src/main/resources/org/vividus/spring-configuration.xml
Outdated
Show resolved
Hide resolved
...r/src/main/resources/META-INF/services/org.vividus.configuration.AbstractPropertiesProcessor
Outdated
Show resolved
Hide resolved
d0b999d
to
11780c8
Compare
f90dacf
to
8894a51
Compare
valfirst
requested changes
Jul 9, 2024
...us-plugin-azure-resource-manager/src/main/java/org/vividus/azure/client/AzureHttpClient.java
Outdated
Show resolved
Hide resolved
...us-plugin-azure-resource-manager/src/main/java/org/vividus/azure/client/AzureHttpClient.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...ger/src/test/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessorTests.java
Outdated
Show resolved
Hide resolved
vividus/src/main/java/org/vividus/configuration/ConfigurationResolver.java
Outdated
Show resolved
Hide resolved
vividus/src/main/java/org/vividus/configuration/VaultStoredPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
d1b4dc5
to
af601b7
Compare
d2e5046
to
949e7fc
Compare
9f2c652
to
4078900
Compare
valfirst
requested changes
Oct 2, 2024
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...zure-resource-manager/src/main/java/org/vividus/azure/client/AzureResourceManagerClient.java
Outdated
Show resolved
Hide resolved
4389314
to
c136357
Compare
b8eb72e
to
eaff0e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5182 +/- ##
============================================
- Coverage 97.69% 97.60% -0.10%
- Complexity 7073 7081 +8
============================================
Files 984 986 +2
Lines 20536 20563 +27
Branches 1344 1344
============================================
+ Hits 20063 20070 +7
- Misses 361 381 +20
Partials 112 112 ☔ View full report in Codecov by Sentry. |
eaff0e6
to
aa556e4
Compare
valfirst
requested changes
Oct 4, 2024
...zure-resource-manager/src/main/java/org/vividus/azure/client/AzureResourceManagerClient.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
...-manager/src/main/java/org/vividus/azure/configuration/AzureKeyVaultPropertiesProcessor.java
Outdated
Show resolved
Hide resolved
24f1c45
to
8f9ba4e
Compare
95293ab
to
1edfd1d
Compare
1edfd1d
to
eef8772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.