chore: fix config for docker-compose #73
Conversation
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -78,7 +78,7 @@ static_resources: | |||
| - name: extproc_service | |||
| connect_timeout: 300s | |||
| per_connection_buffer_limit_bytes: 52428800 | |||
| type: STATIC | |||
| type: STRICT_DNS | |||
There was a problem hiding this comment.
...
envoy-proxy | [2025-09-07 05:15:27.303][1][critical][main] [source/server/server.cc:412] error initializing config ' /etc/envoy/envoy.yaml': Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT: unknown enum value: 'STRICT') has unknown fields
envoy-proxy | [2025-09-07 05:15:27.303][1][info][main] [source/server/server.cc:1038] exiting
envoy-proxy | Protobuf message (type envoy.config.bootstrap.v3.Bootstrap reason INVALID_ARGUMENT: unknown enum value: 'STRICT') has unknown fields| @@ -17,7 +17,7 @@ services: | |||
| networks: | |||
| - semantic-network | |||
| healthcheck: | |||
| test: ["CMD", "nc", "-z", "localhost", "50051"] | |||
| test: ["CMD", "curl","-f", "localhost:8080/health"] | |||
There was a problem hiding this comment.
Have not the command nc on quay.io/centos/centos:stream9
|
can you plz take a look at the failures in CI if u have a moment? Maybe not related to the changes |
liangyuanpeng
force-pushed
the
fix_docker_compose
branch
from
da717c3 to
fe1b720
Compare
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
I just rebase main and then it's green :) |
| @@ -78,7 +78,7 @@ static_resources: | |||
| - name: extproc_service | |||
| connect_timeout: 300s | |||
| per_connection_buffer_limit_bytes: 52428800 | |||
| type: STATIC | |||
| type: STRICT_DNS | |||
|
@liangyuanpeng thanks for contributing! Can you add some text why to run docker compose in the CI? If this is for integration test with envoy, that's a good project for a dedicated CI pipeline. |
|
I still can't say this is for integration testing, because it's just a simple service deployment without any testing. These changes originated from the problems I encountered during my attempt at semantic-router. The current docker-compose configuration fails to start the container properly. A single action job would be great for me |
ok, that explains it. |
|
@Xunzhuo will make the final decision with his expertise in envoy |
liangyuanpeng
force-pushed
the
fix_docker_compose
branch
from
95f672b to
8e0b701
Compare
|
Sorry I don't get the reason to run it in CI, that is supposed to be one of the quickstarts to run vsr in local |
|
I think this is another thing, support to run vsr in docker compose:
|
|
Ok, let me remove it first, But the absence of CI means that no one knows something is broken until they encounter a problem |
Signed-off-by: Lan Liang <[email protected]>
liangyuanpeng
force-pushed
the
fix_docker_compose
branch
from
8e0b701 to
bfe9723
Compare
liangyuanpeng
changed the title
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No