Skip to content

Conversation

@QiliangCui
Copy link
Collaborator

@QiliangCui QiliangCui commented Dec 10, 2025

Description

Move the "if" logic out of command to make the test status cleaner in buildkite.
(redo #1005 by fixing "check_result.sh")

  1. Move "nightly==1" logic to "if" to avoid skipped tests being displayed on UI.
  2. Mark "skipped" for kernel related tests. There is no way to say "if nightly or file changed run tests".

Test

Test skipped

image

Touch kernel file

image

Torch kernel collective file

image

@QiliangCui QiliangCui requested a review from jcyang43 as a code owner December 10, 2025 03:44
@QiliangCui QiliangCui force-pushed the cuiq-add-v7-tests-2 branch 2 times, most recently from 346feba to ff674d0 Compare December 10, 2025 03:50
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@QiliangCui QiliangCui force-pushed the cuiq-add-v7-tests-2 branch 3 times, most recently from 2bebab6 to 3a24595 Compare December 10, 2025 07:29
@QiliangCui QiliangCui changed the title [WIP] Move "skip" out of test command. Move the If nightly==1 check out of command. Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants