Skip to content

Revert "update run_in_docker script for running on local env" #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CienetStingLin wants to merge 1 commit into from
+8 −12
Closed

Revert "update run_in_docker script for running on local env" #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions .buildkite/scripts/setup_docker_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ setup_environment() {
# shellcheck disable=1091
source /etc/environment

if [ -z "${BUILDKITE_COMMIT:-}" ]; then
echo "ERROR: BUILDKITE_COMMIT environment variable is not set." >&2
echo "This script expects BUILDKITE_COMMIT to tag the Docker image." >&2
exit 1
fi

# Cleanup of existing containers and images.
echo "Starting cleanup for ${IMAGE_NAME}..."
# Get all unique image IDs for the repository
Expand Down Expand Up @@ -49,20 +55,10 @@ setup_environment() {

echo "Cleanup complete."

echo "Installing Python dependencies"
python3 -m pip install --progress-bar off buildkite-test-collector==0.1.9
echo "Python dependencies installed"
if [ -z "${BUILDKITE:-}" ]; then
VLLM_COMMIT_HASH=""
TPU_INFERENCE_HASH=$(git log -n 1 --pretty="%H")
else
VLLM_COMMIT_HASH=$(buildkite-agent meta-data get "VLLM_COMMIT_HASH" --default "")
TPU_INFERENCE_HASH="$BUILDKITE_COMMIT"
fi
VLLM_COMMIT_HASH=$(buildkite-agent meta-data get "VLLM_COMMIT_HASH" --default "")

docker build \
--build-arg VLLM_COMMIT_HASH="${VLLM_COMMIT_HASH}" \
--build-arg IS_FOR_V7X="${IS_FOR_V7X:-false}" \
--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${TPU_INFERENCE_HASH}" .

--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${BUILDKITE_COMMIT}" .
}
Loading