[3/N][CI/UT] add spec decode e2e UT && [BUGFIX] fix init_logger bug #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
8 times, most recently
from
7c03c68 to
21b49d7
Compare
MengqingCao
reviewed
Apr 11, 2025
| @@ -148,7 +148,7 @@ jobs: | |||
| - name: Run vllm-project/vllm-ascend key feature test | |||
| if: steps.filter.outputs.speculative_tests_changed | |||
| run: | | |||
| pytest -sv tests/spec_decode | |||
| pytest -sv tests/spec_decode/e2e/test_eagle_correctness.py::test_llama2_eagle_e2e_greedy_correctness | |||
There was a problem hiding this comment.
todo: Revert this when successfully download llama model
There was a problem hiding this comment.
OK, the modification here is just for debugging. I will restore it after debugging is successful.
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
3 times, most recently
from
b612b09 to
2a40cef
Compare
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
2 times, most recently
from
5be0942 to
fbbff4e
Compare
mengwei805
changed the title
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
10 times, most recently
from
3b5a721 to
cc17c3c
Compare
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
6 times, most recently
from
97a7955 to
d791a9b
Compare
Signed-off-by: mengwei805 <[email protected]>
mengwei805
force-pushed
the
v0.7.3-sd-ut-part3
branch
from
d791a9b to
4b9f25b
Compare
wangxiyuan
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
add spec decode e2e UT:
test_eagle_correctness.py;test_mtp_correctness.py; use bf16 model weights;fix init_logger bug:
camem.py;from vllm.logger import init_loggertofrom vllm.logger import loggeroverall situationDoes this PR introduce any user-facing change?
None
How was this patch tested?
Local verification passed