[0.7.3] Update patch timing and CMake to adjust to more user envs #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celestialli
changed the title
wangxiyuan
approved these changes
Apr 16, 2025
wangxiyuan
changed the title
celestialli
changed the title
celestialli
force-pushed
the
patch-1
branch
6 times, most recently
from
e7dd19a to
e0c63d0
Compare
Signed-off-by: Shuqiao Li <[email protected]>
wangxiyuan
reviewed
Apr 21, 2025
| @@ -19,7 +19,6 @@ | |||
| def register(): | |||
| """Register the NPU platform.""" | |||
| # To ensure that the module is correctly replaced, add it at the beginning | |||
| import vllm_ascend.patch_config # noqa: F401 | |||
There was a problem hiding this comment.
why move this on 0.7.3?
There was a problem hiding this comment.
why move this on 0.7.3?
There is a user-feedback problem when patch not taking effect on 073 branch. That is probably due to the patching timing.
wangxiyuan
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To make compile adjust to more user envs.
To make patch timing better to adjust to more conditions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested the same as #416