fix(modules): reject empty word and regex matchers at load - #382
Open
TBX3D wants to merge 1 commit into
Open
Conversation
a word matcher with no words (or a regex matcher with no patterns) evaluates to true under the default AND condition, so it silently matches every response instead of never matching. this is easy to hit via a yaml typo: word: instead of words:, a forgotten words: list, or bad indentation nulling the list. a words: [""] list hits the same bug through strings.Contains(x, ""), which is always true. reject both cases in validateMatchers, the shared load-time check http, dns, and tcp module configs all route through, so the guard applies to every transport that accepts word/regex matchers.
github-actions
Bot
added
modules
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage ? 64.96%
=======================================
Files ? 88
Lines ? 7867
Branches ? 0
=======================================
Hits ? 5111
Misses ? 2365
Partials ? 391 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary2 files changed (+31 -2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a word matcher with no words evaluates to true under the default AND condition, so it matches every response instead of never matching, and a regex matcher with no patterns does the same. the ways to hit it are all yaml typos: word: instead of words:, a forgotten list, indentation nulling it out, and words: [""] gets there too through strings.Contains(x, "") always being true. rejected in validateMatchers, which http, dns and tcp configs all route through.