This repository was archived by the owner on May 10, 2024. It is now read-only.
Depend on a version of go-xdr with working discriminated unions#6
Merged
matthewavery merged 1 commit intovmware-archive:masterfrom Feb 1, 2018
Merged
Conversation
Commit 7592fd7 makes use of the `xdr:"union"` and `xdr:"unioncase=N"` annotations that were submitted in a pull request that has not been merged upstream to davecgh/go-xdr: davecgh/go-xdr#6 Without support for these annotations, the code is unable to parse a valid FSINFO reply. Signed-off-by: Anders Kaseorg <[email protected]>
|
@andersk, VMware has approved your signed contributor license agreement. |
|
Note that both VIC and govmomi/toolbox are using rasky's branch via the gvt vendor manifest: |
|
LGTM |
fdawg4l
approved these changes
Jan 22, 2018
willscott
pushed a commit
to willscott/go-nfs-client
that referenced
this pull request
Jan 3, 2024
* cleanup NFS client * minor fix Co-authored-by: Sandy Xu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 7592fd7 makes use of the
`xdr:"union"`and`xdr:"unioncase=N"`annotations that were submitted in a pull request that has not been merged upstream to davecgh/go-xdr:davecgh/go-xdr#6
Without support for these annotations, the code is unable to parse a valid FSINFO reply.