Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply gofumpt in test packages #8612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 14, 2025

Thank you for contributing to Velero!

Please add a summary of your change

chore: apply gofumpt in test packages

Activation in golangci-lint config will happen in a later PR

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.32%. Comparing base (ddc1bcb) to head (656e150).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8612      +/-   ##
==========================================
+ Coverage   59.16%   59.32%   +0.15%     
==========================================
  Files         370      370              
  Lines       39777    39887     +110     
==========================================
+ Hits        23535    23663     +128     
+ Misses      14745    14728      -17     
+ Partials     1497     1496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai
Copy link
Member

rerunning changelog check.

@kaovilai kaovilai closed this Jan 16, 2025
@kaovilai kaovilai reopened this Jan 16, 2025
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think we've been using gofmt which is official.

Do we wanna use gofumpt which is a fork of gofmt?

I'm tentatively blocking the merge of the PR until the maintainers reach the agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants