govc: add device.sata.add
#3936
Merged
+108
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
force-pushed
the
govc/add-device-sata-add
branch
from
42c817e to
24ae76c
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new device.sata.add command to govc for adding SATA controllers to virtual machines.
- Implements the
device.sata.addcommand with support for adding SATA (AHCI) controllers - Registers the new command in the govc CLI and updates documentation
- Adds test coverage for the new SATA controller functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cli/device/sata/add.go | New file implementing the SATA controller add command |
| govc/main.go | Registers the new SATA device package |
| govc/USAGE.md | Documents the new device.sata.add command |
| govc/test/device.bats | Adds test case for SATA controller functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tenthirtyam
force-pushed
the
govc/add-device-sata-add
branch
2 times, most recently
from
9db8ed8 to
19d4f7f
Compare
- Added 'device.sata.add' command to add SATA controllers to virtual machines. - Registered 'device.sata.add' in the 'govc' CLI entry point. - Updated documentation and test suite to cover the new command. Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
govc/add-device-sata-add
branch
from
19d4f7f to
d6507f0
Compare
dilyar85
approved these changes
Dec 16, 2025
Comment on lines
+61
to
+64
| err = vm.AddDevice(ctx, d) | ||
| if err != nil { | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
Nit: consider changing this to if err := vm.AddDevice(ctx, d); err != nil { ... }?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #3780
How Has This Been Tested?
make govc-testand manually.