Add VirtualVmxnet to EthernetCardTypes #3943
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to commit 76b1cea which added VirtualVmxnet2, this adds support for VirtualVmxnet (the base vmxnet adapter type) to the list of available ethernet card types. This allows users to create VirtualVmxnet network adapters when adding network devices to VMs. Signed-off-by: Zexing Jiang <[email protected]>
Joshzxj
force-pushed
the
add-vmxnet-support
branch
from
83ca508 to
caad5b5
Compare
akutz
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to commit 76b1cea which added VirtualVmxnet2, this adds support for VirtualVmxnet (the base vmxnet adapter type) to the list of available ethernet card types.
VC doesn't explicity block creating VirtualVmxnet network adapters for VM.
Which means it allows users to create VirtualVmxnet network adapters for specific type of VM.
But Govmomi doesn't support and return empty for VirtualVmxnet adaptor. There is no depreciation story of this type of adaptor. So our workflow is still try not block this type of VM.
How Has This Been Tested?
Before the fix, my workflow keeps panic because BaseVirtualEthernetCard return nil
59ef298972a4" panic="interface conversion: interface is nil, not types.BaseVirtualEthernetCard" panicGoValue="&runtime.TypeAssertionError{_interface:(*abi.Type)(nil), concrete:(*abi.Type)(nil), asserted:(*abi.Type)(0x21fdaa0),
After the fix, I tested on my testbed. The govmomi call doesn't return empty type for VirtualVmxnet adaptor which unblocked the test.
Guidelines
Please read and follow the
CONTRIBUTION[guidelines] of this project.Signed-off-by: Zexing Jiang [email protected]