Make shutdown/reboot commands configurable #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems, like Alpine Linux, may not use /sbin/shutdown to power off or reboot. Add configure option so user can set the correct commands. Fixes vmware#235 Signed-off-by: Natanael Copa <[email protected]>
|
@ncopa, VMware has approved your signed contributor license agreement. |
|
Thanks for officially submitting a pull request for the changes you suggested in issue #235 and signing the contributor license agreement. This pull request has been associated with the internal bug filed for issue #235. Your contribution will go through a review process at VMware. An update will be provided once the review is completed. |
|
It would be nice if {REBOOT,SHUTDOWN}_COMMAND was set to the correct value based on $os, rather than having to rely on __sun and __FreeBSD__. |
|
Why this is not alrady merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems, like Alpine Linux, may not use /sbin/shutdown to power off
or reboot. Add configure option so user can set the correct commands.
Fixes #235
Signed-off-by: Natanael Copa [email protected]