Skip to content

[wip] fix: BaseFromReference support for ClusterComputeResource #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SPFZ wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[wip] fix: BaseFromReference support for ClusterComputeResource #2619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion vsphere/internal/helper/computeresource/compute_resource_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,24 @@ type BaseComputeResource interface {
String() string
}

// ClusterFromID locates a ClusterComputeResource by its managed object reference ID.
func ClusterFromID(client *govmomi.Client, id string) (*object.ClusterComputeResource, error) {
finder := find.NewFinder(client.Client, false)

ref := types.ManagedObjectReference{
Type: "ClusterComputeResource",
Value: id,
}

ctx, cancel := context.WithTimeout(context.Background(), provider.DefaultAPITimeout)
defer cancel()
obj, err := finder.ObjectReference(ctx, ref)
if err != nil {
return nil, err
}
return obj.(*object.ClusterComputeResource), nil
}

// StandaloneFromID locates a ComputeResource by its managed object reference ID.
//
// Note this is for base level ComputeResource objects only, and should only be
Expand Down Expand Up @@ -123,7 +141,7 @@ func BaseFromReference(client *govmomi.Client, ref types.ManagedObjectReference)
case "ComputeResource":
return StandaloneFromID(client, ref.Value)
case "ClusterComputeResource":
return StandaloneFromID(client, ref.Value)
return ClusterFromID(client, ref.Value)
}
return nil, fmt.Errorf("unknown object type %s", ref.Type)
}
Expand Down