Skip to content

Conversation

@akli-ime
Copy link

Description

This pull request adds support for returning tags and custom_attributes in the vsphere_virtual_machine data source.

  • Tags are returned as a list of vSphere tag IDs attached to the virtual machine.
  • Custom attributes are returned as a map of custom attribute IDs to their corresponding values.

This improves visibility of vSphere metadata when using the data source.

Related Issue

Fixes #2615

Copy link
Contributor

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please run golangci-lint locally and fix the formatting errors it reports.
Make sure to use v2.1.6 so that it matches the one on the GitHub action.

If you need any help with it just let me know.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move internal imports together in alphabetical order.

Add descriptions for new attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation needs-review Needs Review provider Provider size/s Relative Sizing: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source

3 participants