Skip to content

feat: return tags and custom attributes in d/vsphere_virtual_machine #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacegospod merged 7 commits into from
Jan 20, 2026
Merged

feat: return tags and custom attributes in d/vsphere_virtual_machine #2652

spacegospod merged 7 commits into from
Jan 20, 2026

Conversation

@akli-ime
Copy link
Contributor

@akli-ime akli-ime commented Dec 26, 2025

Description

This pull request adds support for returning tags and custom_attributes in the vsphere_virtual_machine data source.

  • Tags are returned as a list of vSphere tag IDs attached to the virtual machine.
  • Custom attributes are returned as a map of custom attribute IDs to their corresponding values.

This improves visibility of vSphere metadata when using the data source.

Related Issue

Fixes #2615

@akli-ime akli-ime requested a review from a team as a code owner December 26, 2025 16:05
@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review size/s Relative Sizing: Small labels Dec 26, 2025
@akli-ime akli-ime mentioned this pull request Dec 26, 2025
Closed
4 tasks
spacegospod
spacegospod reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please run golangci-lint locally and fix the formatting errors it reports.
Make sure to use v2.1.6 so that it matches the one on the GitHub action.

If you need any help with it just let me know.

tenthirtyam
tenthirtyam requested changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move internal imports together in alphabetical order.

Add descriptions for new attributes.

spacegospod
spacegospod previously requested changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akli-ime Looks good, I tried to apply @tenthirtyam 's suggestions into comments to help move this forward.

@akli-ime
Copy link
Contributor Author

akli-ime commented Jan 19, 2026

@spacegospod Thanks a lot! I’ve reviewed the comments and really appreciate you taking the time to incorporate @tenthirtyam’s suggestions. This is very helpful for moving things forward.

@spacegospod
Copy link
Contributor

spacegospod commented Jan 19, 2026

@spacegospod Thanks a lot! I’ve reviewed the comments and really appreciate you taking the time to incorporate @tenthirtyam’s suggestions. This is very helpful for moving things forward.

Looks like 4 imports got duplicated and are failing the lint

akli-ime and others added 6 commits January 20, 2026 09:10
@akli-ime @tenthirtyam
feat: add tags and custom attributes
5a23acd
@akli-ime @tenthirtyam
feat: Doc add tags and custom attributes
a4fdce5
@akli-ime @tenthirtyam
code review
3abbd78
@akli-ime @spacegospod @tenthirtyam
Update vsphere/data_source_vsphere_virtual_machine.go
1a362f1 
Co-authored-by: Stoyan Zhelyazkov <156204153+spacegospod@users.noreply.github.com>
@akli-ime @spacegospod @tenthirtyam
Update vsphere/data_source_vsphere_virtual_machine.go
704396c 
Co-authored-by: Stoyan Zhelyazkov <156204153+spacegospod@users.noreply.github.com>
@akli-ime @spacegospod @tenthirtyam
Update vsphere/data_source_vsphere_virtual_machine.go
c5c0ff1 
Co-authored-by: Stoyan Zhelyazkov <156204153+spacegospod@users.noreply.github.com>
@tenthirtyam
Copy link
Contributor

tenthirtyam commented Jan 20, 2026

@spacegospod - I've optimized the imports and have rebased the branch. Awaiting the CI to pass.

@tenthirtyam
chore: optimize imports
8769aff 
Optimize the imports.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam changed the title Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source feat: return tags and custom attributes in the d/vsphere_virtual_machine Jan 20, 2026
@tenthirtyam tenthirtyam changed the title feat: return tags and custom attributes in the d/vsphere_virtual_machine feat: return tags and custom attributes in d/vsphere_virtual_machine Jan 20, 2026
tenthirtyam
tenthirtyam approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacegospod spacegospod merged commit e3cd059 into vmware:main Jan 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@spacegospod spacegospod Awaiting requested review from spacegospod

Assignees

No one assigned

Labels

documentation Documentation needs-review Needs Review provider Provider size/s Relative Sizing: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for returning tags and custom_attributes in the d/vsphere_virtual_machine data source

3 participants

@akli-ime @spacegospod @tenthirtyam