Merged
Conversation
caglar10ur
approved these changes
Feb 28, 2017
Contributor
caglar10ur
left a comment
caglar10ur
left a comment
There was a problem hiding this comment.
I've one comment about vendor directory, otherwise LGTM
| { | ||
| "importpath": "github.com/davecgh/go-xdr/xdr2", | ||
| "repository": "https://github.com/davecgh/go-xdr", | ||
| "repository": "https://github.com/rasky/go-xdr", |
Contributor
There was a problem hiding this comment.
this uses rasky but we vendor and use davecgh one. Is it intentional?
Member
Author
There was a problem hiding this comment.
yes, meant to mention that - this pulls in davecgh/go-xdr#6 until it lands, we need it for xdr optional pointer field support.
dougm
force-pushed
the
toolbox
branch
6 times, most recently
from
501b14e to
302ec9f
Compare
rajanashok
approved these changes
Feb 28, 2017
mdubya66
approved these changes
Feb 28, 2017
Contributor
mdubya66
left a comment
mdubya66
left a comment
There was a problem hiding this comment.
Vendor updates are lgtm
Optional fields (aka xdr_pointer) support required for issue vmware#3824
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Feb 13, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Feb 13, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Feb 14, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
ading007
pushed a commit
to ading007/vic-product
that referenced
this pull request
Feb 14, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
ading007
pushed a commit
to ading007/vic-product
that referenced
this pull request
Feb 14, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Feb 14, 2020
Seems the UI difference is newer vCenter uses the VirtualMachine guest.net property here, but older vCenter UI used the guest.ipAddress field + guest.net. The toolbox populates both fields, however guest.net requires a fork of the xdr package: vmware/vic#4057. It looks like the vic-product repo does not use the same vendored package as vic. This fix uses the same xdr2 package as vic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3824