Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/community form #67

Closed
wants to merge 49 commits into from
Closed

Conversation

Anexon
Copy link

@Anexon Anexon commented Jul 5, 2020

Hi there!

Here is what I think could work as next step into creating data structure for new community using a reactive angular form. What's in the pr:

  • Angular form groups to collect information about community and collaborators with input validations.
  • Google Maps Places to autocomplete address location and get latitude and longitude of community (needs enabled API).
  • Copy to clipboard generated json text according to community schema.
  • Link to steps to update repository and add the community.

With this we will have a digital we to generate the required schema that could be updated in the future to upload its content to firebase just by adding a service to the form component.

Here you can see working video of the form:
form usage gif

Let me know what do you think,
Best!

#57

@tonivj5
Copy link
Member

tonivj5 commented Jul 5, 2020

Wow @Anexon, this is awesome 🏆

I'll review it ASAP 👍

@tonivj5 tonivj5 requested review from Caballerog, tonivj5 and NyaGarcia and removed request for Caballerog and tonivj5 July 5, 2020 17:35
queda pendiente integrar los estilos de ionic para los inputs y logica de servicio
@Anexon
Copy link
Author

Anexon commented Jul 21, 2020

Hi there!
How are you doing? Let me know if need something to merge this.

@tonivj5
Copy link
Member

tonivj5 commented Jul 21, 2020

Hey, I haven't forgot of you. I've been very busy these weeks. I'll try to review it later this week

Copy link
Member

@tonivj5 tonivj5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a long review, most of comments are suggestion, if you are okay with them, accept it. If you need help with it, let me know 👍

Anexon and others added 12 commits July 28, 2020 19:06
Anexon and others added 23 commits July 28, 2020 19:15
@Anexon
Copy link
Author

Anexon commented Jul 28, 2020

@tonivj5 wow, what a review!
I appreciate it very much, you did a great work in there; great code simplification and cleaning. I've took a couple of personal notes for next contributions :D!
I would like have done this review on a live session because I don't fully understand some suggestions related to move from contructor to @input and a some other. But I'm sure we can chat about them in some moment in the future :).

Thank you very much for your work @tonivj5 . I'm eager to see it in next deploys and start collaborating in other issues!

@tonivj5
Copy link
Member

tonivj5 commented Jul 29, 2020

I would like have done this review on a live session because I don't fully understand some suggestions related to move from contructor to @input and a some other. But I'm sure we can chat about them in some moment in the future :).

Sure! No problem 😄👍

@Anexon Anexon closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants