feat(cli): support for default file/dir ignore config in ovcli.conf#1393
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Apr 13, 2026
Merged
feat(cli): support for default file/dir ignore config in ovcli.conf#1393qin-ctx merged 1 commit intovolcengine:mainfrom
ovcli.conf#1393qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
1 task
PR Code Suggestions ✨Explore these optional code suggestions:
|
ovcli.conf
qin-ctx
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add default upload filter support in
ovcli.conffor CLIadd-resource, and merge those defaults with per-command CLI flags (--ignore-dirs,--include,--exclude) instead of overriding.Also extend Python
openviking_cliconfig schema so newuploadsection is accepted without validation failure.Related Issue
Fixes #1386
Type of Change
Changes Made
crates/ov_cli/src/config.rs) withupload.ignore_dirs,upload.include,upload.exclude.add-resourceflow (crates/ov_cli/src/main.rs): config defaults + CLI values merged additively.ignore_dirs/include/excludestill optional CSV strings sent to/api/v1/resources).OVCLIConfig(openviking_cli/utils/config/ovcli_config.py) with optional nesteduploadmodel for compatibility.uploadsection and rejecting unknown nesteduploadfields.crates/ov_cli/README.mddocs/en/guides/01-configuration.mddocs/zh/guides/01-configuration.mdTesting
Test commands/results:
cargo test -p ov_cli✅ (15 passed)pytest --noconftest tests/client/test_http_client_config.py -q✅ (6 passed)pytest tests/client/test_http_client_config.pySIGSEGVvia global test bootstrap in this setupChecklist
Screenshots (if applicable)
N/A (CLI/config/docs changes only).
Additional Notes
.gitignoresupport intentionally not implemented in this PR.openviking_clicompatibility update included becauseOVCLIConfiguses strictextra="forbid"; without this, addinguploadtoovcli.confwould break Python config loading.cargo fmtapplied; includes minor format-only changes.