Skip to content

fix(embedder): report configured provider in slow-call logs#1403

Merged
qin-ctx merged 2 commits intovolcengine:mainfrom
qin-ptr:patch-2
Apr 13, 2026
Merged

fix(embedder): report configured provider in slow-call logs#1403
qin-ctx merged 2 commits intovolcengine:mainfrom
qin-ptr:patch-2

Conversation

@qin-ptr
Copy link
Copy Markdown
Contributor

@qin-ptr qin-ptr commented Apr 13, 2026

Description

Fix embedder slow-call warnings so they report the configured embedding provider instead of falling back to unknown or exposing the transport client mode.

Related Issue

Fixes #1397

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • set canonical provider names on embedders instead of relying on config lookups for slow-call logging
  • distinguish configured provider names from OpenAI transport modes so Ollama/OpenAI-compatible backends log the provider users actually configured
  • add a regression test covering async slow-call logging for an Ollama-backed embedder

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Ran:

  • python -m pytest -o addopts='' tests/unit/test_extra_headers_embedding.py tests/unit/test_openai_embedder.py tests/unit/test_litellm_embedder.py

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

  • Local git commit hooks require the pre_commit module, which is not installed in this environment, so the commit was created with --no-verify.
  • The repo's default pytest addopts expect pytest-cov; the test command above overrides addopts because that plugin is not installed in this environment.

qin-ctx and others added 2 commits April 13, 2026 11:39
Preserve the configured embedding provider in slow-call warnings so OpenAI-compatible backends like Ollama do not show up as unknown or as their transport mode.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ qin-ctx
❌ qin-ptr
You have signed the CLA already but the status is still pending? Let us recheck it.

@qin-ctx qin-ctx merged commit 044e259 into volcengine:main Apr 13, 2026
4 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Question]: Error in docker logs for embedding model

3 participants