fix(openclaw-plugin): default recall to assemble and bound afterTurn#1424
Open
0xble wants to merge 3 commits intovolcengine:mainfrom
Open
fix(openclaw-plugin): default recall to assemble and bound afterTurn#14240xble wants to merge 3 commits intovolcengine:mainfrom
0xble wants to merge 3 commits intovolcengine:mainfrom
Conversation
Move the OpenClaw plugin to an assemble-first recall path when the context-engine slot is active, keep before_prompt_build as compatibility-only behavior, and teach the setup helper to resolve the active OpenClaw config file so json5-based installs upgrade cleanly.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Collaborator
|
“这些 logger.info 现在会在非 debug 模式下输出 session context / summary / message preview,默认日志会带上用户内容。建议收敛到 logFindRequests/debug 开关后,或只保留计数与 trace_id 等非内容信息。” 代码有confilict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Default the OpenClaw plugin to an assemble-first recall path when OpenViking
owns the
contextEngineslot, and fail open if the plugin's hot-path capturework gets slow.
This avoids running hook-based recall and context-engine recall on the same
reply path, updates the setup helper to resolve the active OpenClaw config
file so existing installs upgrade cleanly, and bounds
afterTurnauto-captureso slow OV writes do not keep an OpenClaw run open after the model already
replied.
Related Issue
Related to #1283
Type of Change
Changes Made
assemble()by default and added arecallPathconfig so
before_prompt_buildonly runs in explicit compatibility mode.recallPath=assemble, disable prompt injection in context-engine mode, andresolve the active OpenClaw config file instead of assuming
openclaw.json.afterTurnauto-capture with a fail-open timeout so slow OpenVikingsession writes cannot block OpenClaw run completion after the assistant has
already produced a reply.
setup-helper config handling, and
afterTurntimeout fallback behavior.Testing
Commands run:
npm test -- tests/ut/config.test.ts tests/ut/context-engine-assemble.test.ts tests/ut/plugin-normal-flow-real-server.test.ts tests/ut/plugin-bypass-session-patterns.test.ts tests/ut/tools.test.ts tests/ut/local-startup-failure.test.ts tests/ut/local-startup-bad-config-real.test.tsnpm test -- tests/ut/context-engine-afterTurn.test.ts tests/ut/context-engine-assemble.test.tsnpm testChecklist
Screenshots (if applicable)
N/A
Additional Notes
OpenViking plugin at v0.3.5.
gateway-timeout fallback behavior.