Open
Conversation
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- instantiate TypeAdapter before validating typed JsonUtils.loads input\n- export JsonUtils from memory utils\n- add regression coverage for raw dict and Pydantic model loading\n\n## Validation\n- python3 -m py_compile openviking/session/memory/utils/json_parser.py openviking/session/memory/utils/init.py tests/session/memory/test_json_stability.py\n- PYTHONPATH=. uv run --no-project --with ruff python -m ruff check --select I,F401 openviking/session/memory/utils/json_parser.py openviking/session/memory/utils/init.py tests/session/memory/test_json_stability.py\n- PYTHONPATH=. uv run --no-project --with pydantic --with json-repair python - <<'PY' ... direct JsonUtils.loads regression check\n\nNote: full pytest through uv run is blocked in this local environment because editable install builds the bundled Rust AGFS/CLI and the installed CommandLineTools libxcrun.dylib has an incompatible architecture. Running pytest without installing the project then fails in tests/conftest.py because the bundled AGFS client is unavailable.