Open
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
ZaynJarvis
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add focused check_ollama unit coverage for missing/non-Ollama configs\n- verify embedding and VLM Ollama api_base values are passed to the health check\n- cover the unreachable Ollama diagnostic path without requiring a real Ollama process\n\n## Validation\n- python3 -m py_compile tests/cli/test_doctor.py\n- PYTHONPATH=. uv run --no-project --with ruff python -m ruff check tests/cli/test_doctor.py\n- PYTHONPATH=. uv run --no-project --with pytest --with pytest-cov --with httpx --with pydantic --with pyyaml --with loguru --with rich --with json-repair python -m pytest --confcutdir=tests/cli tests/cli/test_doctor.py -k ollama