Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing support #20

Merged
merged 13 commits into from
Apr 2, 2024
Merged

Add tracing support #20

merged 13 commits into from
Apr 2, 2024

Conversation

willkill07
Copy link
Contributor

@willkill07 willkill07 commented Mar 29, 2024 •
edited
Loading

  • Add optional tracing module (including NvtxLayer)
  • Add support of maintaining internal mappings for String -> RegisteredString
    • Prefer RegisteredString within a domain context. Whenever a builder is used, we will always convert to RegisteredString.
  • Add support of maintaining internal mappings for String -> Category
  • Enable dynamic category creation via domain::EventAttributesBuilder::category_name
  • Update documentation
  • General code cleanup
  • Add panic-asserting tests

Screenshot of example/tracing.rs output:
Screenshot of example/tracing.rs output

@willkill07 willkill07 force-pushed the feature-tracing branch 2 times, most recently from 8f8b798 to 687c0d0 Compare March 29, 2024 21:07
@willkill07
Add tracing support
4c29e6e 
Signed-off-by: Will Killian <[email protected]>
@willkill07 willkill07 requested a review from mbrobbel March 29, 2024 21:13
mbrobbel
mbrobbel reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@mbrobbel mbrobbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

src/color.rs Show resolved Hide resolved
src/tracing/mod.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@willkill07
Ensure matching domains; prefer for tracing
3b0774a 
Signed-off-by: Will Killian <[email protected]>
@willkill07
Prefer eq to addr_eq
5393527 
Signed-off-by: Will Killian <[email protected]>
@willkill07
Add panic tests
ecab43c 
Signed-off-by: Will Killian <[email protected]>
@willkill07
Improve tracing API
2a709fb 
Signed-off-by: Will Killian <[email protected]>
@willkill07 willkill07 requested a review from mbrobbel April 2, 2024 13:01
@willkill07
Add hex color support
d38cd37 
Signed-off-by: Will Killian <[email protected]>
mbrobbel
mbrobbel approved these changes Apr 2, 2024
View reviewed changes
src/tracing/mod.rs Outdated Show resolved Hide resolved
src/tracing/mod.rs Outdated Show resolved Hide resolved
@willkill07
Add From<u32> for Color
36be79b 
Signed-off-by: Will Killian <[email protected]>
@willkill07 willkill07 merged commit 8a34429 into main Apr 2, 2024
5 checks passed
@willkill07 willkill07 deleted the feature-tracing branch April 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrobbel mbrobbel mbrobbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willkill07 @mbrobbel