fix: binding secrets as ARGS in clients dockerfile (#77)

voltrondata · Feb 16, 2024 · 80f87d1 · 80f87d1
1 parent 1ab5915
commit 80f87d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/client/Dockerfile b/client/Dockerfile
@@ -1,4 +1,8 @@
 FROM node:18-alpine as builder
+
+ARG VITE_SESSION_SECRET
+ENV VITE_SESSION_SECRET=$VITE_SESSION_SECRET
+
 WORKDIR /app
 COPY . .
 

diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -12,13 +12,16 @@ services:
       - fiddle-network
 
   client:
-    build: ./client
+    build:
+      context: ./client
+      args:
+      - VITE_SESSION_SECRET=$VITE_SESSION_SECRET
     ports:
       - "80:8080"
     networks:
       - fiddle-network
     environment:
-     - VITE_SESSION_SECRET=$VITE_SESSION_SECRET
+     - NODE_ENV=production
 
 networks:
   fiddle-network: