Skip to content

Conversation

SimonMellerin
Copy link

Hi,
I told you about this PR in June, well I was quite busy.. I've finally find some time to do it..

I've add some options to the alarm clock feature.
The idea here is to be able to choose for which weekdays alarm has to be enable.

I've also made a PR for Volumio : volumio/Volumio2#1640

This is my first contribution, I tried to respect your code style, be nice :)

@SimonMellerin
Copy link
Author

I've a fail with travis but I can't understand why, can some one help me with this ?

@xipmix
Copy link
Contributor

xipmix commented Nov 21, 2019

Not sure why the travis build is failing, but it seems it's missing quite a few things in the 'scripts' step that may be causing the rest to fall over. Have you tried a fresh clone of upstream/master and reapplying your changes on top?

It would be nice to fix the 'CRATE_PLAYLIST_FIRST' typo (should be CREATE_..) but that can come later.

@xipmix
Copy link
Contributor

xipmix commented Nov 21, 2019

When I try to build in my checkout (693ee9a Oauth Handler) I get the same failures.

$ export PATH=`pwd`/node_modules/.bin:${PATH}
$ bash ./deploy.sh
$ echo $?
128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants