Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vortex-duckdb/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use bindgen::Abi;
const DUCKDB_RELEASES_URL: &str = "https://github.com/duckdb/duckdb/releases/download";
const DUCKDB_SOURCE_RELEASE_URL: &str = "https://github.com/duckdb/duckdb/archive/refs/tags";
const DUCKDB_SOURCE_COMMIT_URL: &str = "https://github.com/duckdb/duckdb/archive";
const DEFAULT_DUCKDB_VERSION: &str = "1.5.3";

const BUILD_ARTIFACTS: [&str; 3] = ["libduckdb.dylib", "libduckdb.so", "libduckdb_static.a"];

Expand Down Expand Up @@ -384,7 +385,7 @@ fn main() {
// e.g. reordering fields in C++ structs.
let version = env::var("DUCKDB_VERSION")
// You can also change this version to a commit hash
.unwrap_or_else(|_| "1.5.2".to_owned());
.unwrap_or_else(|_| DEFAULT_DUCKDB_VERSION.to_owned());
let version = DuckDBVersion::from(&version);
match &version {
DuckDBVersion::Release(v) => println!("cargo:info=Using DuckDB release version: {v}"),
Expand Down
1 change: 1 addition & 0 deletions vortex-duckdb/src/convert/dtype.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ impl FromLogicalType for DType {
.collect::<VortexResult<_>>()?,
nullability,
),
DUCKDB_TYPE::DUCKDB_TYPE_VARIANT => DType::Variant(nullability),
DUCKDB_TYPE::DUCKDB_TYPE_TIME_TZ => todo!(),
DUCKDB_TYPE::DUCKDB_TYPE_INTERVAL => todo!(),
DUCKDB_TYPE::DUCKDB_TYPE_ENUM => todo!(),
Expand Down
Loading