Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/rust-instrumented.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,19 @@ jobs:
sccache: s3
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- uses: ./.github/actions/setup-prebuild
Comment thread
0ax1 marked this conversation as resolved.
- name: Install LLVM tools
run: |
rustup component add llvm-tools || rustup component add llvm-tools-preview
- name: Rust Tests
if: ${{ matrix.suite == 'tests' }}
run: |
cargo nextest run --locked --workspace --all-features --no-fail-fast
- name: Generate coverage report
run: |
set -euo pipefail
LLVM_TOOLS_BIN="$(dirname "$(rustup which llvm-profdata)")"
grcov . --binary-path target/debug/ -s . -t lcov --llvm --ignore-not-existing \
--llvm-path "${LLVM_TOOLS_BIN}" \
--threads $(nproc) \
--ignore '../*' --ignore '/*' --ignore 'fuzz/*' --ignore 'vortex-bench/*' \
--ignore 'home/*' --ignore 'xtask/*' --ignore 'target/*' --ignore 'vortex-error/*' \
Expand All @@ -62,6 +68,7 @@ jobs:
--ignore 'vortex-ffi/examples/*' --ignore '*/arbitrary/*' --ignore '*/arbitrary.rs' --ignore 'vortex-cxx/*' \
--ignore benchmarks/* --ignore 'vortex-test/*' \
-o ${{ env.GRCOV_OUTPUT_FILE }}
test -s ${{ env.GRCOV_OUTPUT_FILE }}
- name: Codecov
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
with:
Expand Down
6 changes: 3 additions & 3 deletions benchmarks-website/server/tests/landing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,11 @@ async fn landing_page_honours_filter_query_params() -> Result<()> {
/// full history via the explicit `/api/chart/{slug}?n=all` refetch.
#[tokio::test]
async fn landing_first_group_shard_caps_commits() -> Result<()> {
// 250 commits is comfortably above the 100-commit artifact cap so the
// 101 commits is the smallest fixture above the 100-commit artifact cap, so the
// cap actually kicks in. `seed_long_history` only seeds the Random-Access
// group; with the canonical group ordering Random Access sorts first.
let server = Server::start().await?;
seed_long_history(&server, 250).await?;
seed_long_history(&server, 101).await?;

let client = reqwest::Client::new();
let body = client.get(server.url("/")).send().await?.text().await?;
Expand Down Expand Up @@ -454,7 +454,7 @@ async fn landing_first_group_shard_caps_commits() -> Result<()> {
assert_eq!(
commits.len(),
100,
"with 250 seeded commits the shard payload should be exactly the \
"with 101 seeded commits the shard payload should be exactly the \
100-commit cap; got {}",
commits.len(),
);
Expand Down
4 changes: 2 additions & 2 deletions benchmarks-website/server/tests/permalinks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use self::common::seed_long_history;
#[tokio::test]
async fn permalink_pages_default_to_latest_100_and_opt_into_full_history() -> Result<()> {
let server = Server::start().await?;
seed_long_history(&server, 200).await?;
seed_long_history(&server, 101).await?;

let chart_slug = pick_chart_slug(&server, |s| s == "Random Access").await?;
let group_slug = pick_group_slug(&server, |s| s == "Random Access").await?;
Expand Down Expand Up @@ -61,7 +61,7 @@ async fn permalink_pages_default_to_latest_100_and_opt_into_full_history() -> Re
.as_array()
.context("all commits is array")?
.len(),
200,
101,
"/chart?n=all should inline the full raw history",
);

Expand Down
Loading