VortexSession API cleanup pass#8503
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | slice_empty_vortex |
310 ns | 368.3 ns | -15.84% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/session-new-api-pass (70756d4) with develop (b4c85b6)
Footnotes
-
1319 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
d86eea0 to
8cce41b
Compare
fe9d7d4 to
ff676f7
Compare
5682184 to
ab39ca5
Compare
ab39ca5 to
c3bd22c
Compare
7dd3548 to
7d09a33
Compare
7d09a33 to
70756d4
Compare
|
We want shorthand methods for the builders as well so we don't have to use |
robert3005
left a comment
There was a problem hiding this comment.
I missed the part where this makes it difficult to add things at runtime and will force to teach consumers about unloading. Unloading can be difficult since you need to track all the state that you have borrowed from the session
Summary
This PR makes the final pass to make the
VortexSessionimmutable, removing theto_builderfunction and trying to clear up all call sites.I've also tried to find all docs referencing it, but the change touches so many places I might've missed something.
One big change here is changing
array_session(which I think I introduced?) todefault_session_builder