Skip to content

Remove arrow usage from VarBin::compare, VarBinView::filter and BoolArray::from_iter#8695

Merged
robert3005 merged 1 commit into
developfrom
rk/removemorearrow
Jul 9, 2026
Merged

Remove arrow usage from VarBin::compare, VarBinView::filter and BoolArray::from_iter#8695
robert3005 merged 1 commit into
developfrom
rk/removemorearrow

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

All of these operations don't need to depend on arrow

@robert3005 robert3005 added the changelog/chore A trivial change label Jul 9, 2026
@robert3005 robert3005 force-pushed the rk/removemorearrow branch from 13c1939 to ac1e514 Compare July 9, 2026 10:34
@codspeed-hq

codspeed-hq Bot commented Jul 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 29.62%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
✅ 1614 untouched benchmarks
⏩ 42 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation copy_nullable[65536] 1,027.7 µs 573.1 µs +79.33%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%
Simulation copy_non_nullable[65536] 908.6 µs 794.1 µs +14.42%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/removemorearrow (f8996bf) with develop (11f15a9)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

…rray::from_iter

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 force-pushed the rk/removemorearrow branch from ac1e514 to f8996bf Compare July 9, 2026 12:25
@robert3005 robert3005 requested review from 0ax1 and AdamGS July 9, 2026 15:59
@robert3005 robert3005 enabled auto-merge (squash) July 9, 2026 16:07
@robert3005 robert3005 merged commit 24ad8fd into develop Jul 9, 2026
70 of 72 checks passed
@robert3005 robert3005 deleted the rk/removemorearrow branch July 9, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants