Skip to content

cuda: build.rs add trigger#8708

Merged
0ax1 merged 1 commit into
vortex-data:developfrom
mag1c1an1:cuda
Jul 10, 2026
Merged

cuda: build.rs add trigger#8708
0ax1 merged 1 commit into
vortex-data:developfrom
mag1c1an1:cuda

Conversation

@mag1c1an1

@mag1c1an1 mag1c1an1 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: mag1cian <mag1cian@icloud.com>
@0ax1
0ax1 self-requested a review July 10, 2026 07:46
@0ax1
0ax1 enabled auto-merge (squash) July 10, 2026 07:47
@0ax1 0ax1 added the changelog/chore A trivial change label Jul 10, 2026
@0ax1

0ax1 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@mag1c1an1 Good catch, thank you!

@0ax1
0ax1 merged commit a649d75 into vortex-data:develop Jul 10, 2026
80 of 82 checks passed
@codspeed-hq

codspeed-hq Bot commented Jul 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1666 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation rebuild_naive 91.4 µs 101.6 µs -10.04%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 244.4 ns +11.93%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mag1c1an1:cuda (71eeeed) with develop (1bcaf3f)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

connortsui20 pushed a commit that referenced this pull request Jul 13, 2026
rebuild_naive flipped between ~91us and ~105us (reported as -10% to -16%
regressions or +15% improvements depending on the baseline) on about ten
recently merged PRs that never touched vortex-zstd or ListView rebuild,
including a docs-only Spark PR (#8728) and a build.rs-only CUDA PR (#8708).

The benchmark cannot be stabilized: its trace is dominated by zstd's internal
window/output copies (glibc memcpy resolved per runner image via ifunc), not
by Vortex code. It is also of little value: the fixture is degenerate - a
4-string dictionary with all-zero offsets - and the rebuild paths it nominally
covers are benchmarked properly across element types and list shapes in
vortex-array/benches/listview_rebuild.rs. Remove it rather than keep a noise
source; the divan dev-dependency goes with it since this was the crate's only
benchmark.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T6PPcdrqcNeUkfi1EGd4oC
connortsui20 pushed a commit that referenced this pull request Jul 13, 2026
rebuild_naive flipped between ~91us and ~105us (reported as -10% to -16%
regressions or +15% improvements depending on the baseline) on about ten
recently merged PRs that never touched vortex-zstd or ListView rebuild,
including a docs-only Spark PR (#8728) and a build.rs-only CUDA PR (#8708).

The benchmark cannot be stabilized: its trace is dominated by zstd's internal
window/output copies (glibc memcpy resolved per runner image via ifunc), not
by Vortex code. It is also of little value: the fixture is degenerate - a
4-string dictionary with all-zero offsets - and the rebuild paths it nominally
covers are benchmarked properly across element types and list shapes in
vortex-array/benches/listview_rebuild.rs. Remove it rather than keep a noise
source; the divan dev-dependency goes with it since this was the crate's only
benchmark.

Signed-off-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T6PPcdrqcNeUkfi1EGd4oC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build.rs caches stale PTX when nvcc availability changes (no rerun-if-env-changed=PATH)

2 participants